crypto: simplify exportKeyingMaterial #31922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
crypto
addaleax
approved these changes
Feb 24, 2020
Co-Authored-By: Anna Henningsen <[email protected]>
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Feb 24, 2020
jasnell
approved these changes
Feb 24, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
devnexen
approved these changes
Feb 24, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 51cae73 |
Trott
pushed a commit
that referenced
this pull request
Mar 1, 2020
PR-URL: #31922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
PR-URL: #31922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
|
depends on #31814 to land on v12.x |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#31922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #31922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolinstead ofint.Buffer::HasInstance. We shouldn't silently ignore non-buffers, andByteSource::FromBufferwillCHECKthat the input is aBufferanyway.keytocontext, because that's what it is.useContexttouse_contextfor consistency with the rest ofnode_crypto.cc.IsUndefinedinstead ofIsNull, because the JavaScript layer will always either passundefinedor aBuffer.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes